Ensure the NetworkManager persistent connections are copied unless disabled explicitly#2299
Merged
Ensure the NetworkManager persistent connections are copied unless disabled explicitly#2299
Conversation
teclator
changed the title
teclator
force-pushed
the
copy_network_fix
branch
from
40fc259 to
68b9cce
Compare
cfconrad
approved these changes
Apr 28, 2025
teclator
force-pushed
the
copy_network_fix
branch
from
68b9cce to
4f821d7
Compare
imobachgs
approved these changes
Apr 29, 2025
| if getargbool 1 inst.copy_network; then | ||
| # If there is some explicit network configuration provided through the ip= kernel cmdline option | ||
| # then we set the config server configuration diabling the DHCP auto configuration for ethernet | ||
| # devices and also copying the configuration persistently (bsc#1241224, bsc#122486, bsc#1239777, |
Contributor
There was a problem hiding this comment.
np: do you need persistently here?
Contributor
Author
There was a problem hiding this comment.
we could replace it by to /etc..
…gama-conf.sh Co-authored-by: Imobach González Sosa <igonzalezsosa@suse.com>
Merged
imobachgs
added a commit
that referenced
this pull request
May 26, 2025
Prepare to release Agama 15: * #2258 * #2270 * #2277 * #2279 * #2283 * #2284 * #2285 * #2286 * #2287 * #2288 * #2291 * #2292 * #2293 * #2295 * #2297 * #2299 * #2300 * #2301 * #2302 * #2303 * #2305 * #2306 * #2307 * #2308 * #2309 * #2313 * #2314 * #2315 * #2317 * #2318 * #2319 * #2320 * #2321 * #2322 * #2323 * #2324 * #2325 * #2328 * #2329 * #2330 * #2331 * #2335 * #2336 * #2337 * #2338 * #2339 * #2340 * #2342 * #2345 * #2346 * #2348 * #2349 * #2350 * #2351 * #2352 * #2353 * #2354 * #2355 * #2357 * #2358 * #2359 * #2360 * #2361 * #2362 * #2363 * #2364 * #2365 * #2366 * #2368 * #2369 * #2370 * #2371 * #2372 * #2374 * #2377 * #2378 * #2379 * #2380 * #2381 * #2382 * #2384 * #2385 * #2386 * #2388 * #2389 * #2390 * #2391 * #2392 * #2394 * #2397 * #2398 * #2401 * #2403
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If there is no network configuration specified through the kernel cmdline then the /run/agama/copy_network is not created and that is wrong as the network configuration written persistently during installation will not be copied to the target system.
Solution
Modify the check discarding the copy of the network files if disabled explicitly (it will check if the /run/agama/not_copy_network file exists).
Testing